Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better react mermaid #9

Merged
merged 3 commits into from
Oct 2, 2024
Merged

Better react mermaid #9

merged 3 commits into from
Oct 2, 2024

Conversation

abefernan
Copy link
Collaborator

Replacing the inner html link from a sequence diagram depended on a setTimeout which caused a flash of badly rendered diagram. This makes the rendering more robust and also tweaks the styles to fit the default from the component library.

better-react-mermaid

@abefernan abefernan self-assigned this Sep 30, 2024
hashedone
hashedone previously approved these changes Oct 1, 2024
Copy link

@hashedone hashedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit.

Base automatically changed from mermaid-span-link to main October 2, 2024 10:41
@abefernan abefernan dismissed hashedone’s stale review October 2, 2024 10:41

The base branch was changed.

@abefernan abefernan merged commit 6cd05ad into main Oct 2, 2024
1 check passed
@abefernan abefernan deleted the better-react-mermaid branch October 2, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants